Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 1 x lifetime patch #4933

Merged
merged 2 commits into from Aug 13, 2014
Merged

7 1 x lifetime patch #4933

merged 2 commits into from Aug 13, 2014

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Aug 12, 2014

Pull request to fix: hypernews posting - Urgent issue with pythia6 + Tauola++ in 71x and 72x (was Fwd: 720pre3 standard relval samples).
In the hypernews, it was reported that undecayed taus were causing aborts in on an insert statement. There was only one line that could cause this problem (ie setting the tau lifetime for tauola to a non-zero value). This has been changed back and a substitute calculation of the tau decay length has been added with code to propagate it to the full decay chain.
This code has been tested both on default test configurations (see test dir) and on the relval sample that crashed(however, since the generator depends on random seeds, only a limited test could be performed).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @inugent for CMSSW_7_1_X.

7 1 x lifetime patch

It involves the following packages:

GeneratorInterface/TauolaInterface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@slava77 slava77 mentioned this pull request Aug 13, 2014
davidlange6 added a commit that referenced this pull request Aug 13, 2014
@davidlange6 davidlange6 merged commit 289662f into cms-sw:CMSSW_7_1_X Aug 13, 2014
bendavid added a commit to bendavid/cmssw that referenced this pull request Aug 19, 2014
…tch"

This reverts commit 289662f, reversing
changes made to 70e681b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants