Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport evtgen photospp to7 1 x #4970

Merged
4 commits merged into from Sep 17, 2014
Merged

Backport evtgen photospp to7 1 x #4970

4 commits merged into from Sep 17, 2014

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Aug 15, 2014

This pull request depends on cmsdist pull #916. This request is being put in before the cmsdist patch at the request of Josh Bendavid Josh.Bendavid@cern.ch and Vitaliano Ciulli vitaliano.ciulli@cern.ch. Before merging please and for any question please contact them. The pull request 4968 may have a small problem merging with ExternalDecayDriver.cc(h). Just use the one in the 4968 the only difference is the addition of lines.

inugent added 4 commits August 5, 2014 13:48
…ssw into from-CMSSW_7_1_X_2014-08-15-0200

Conflicts:
	GeneratorInterface/TauolaInterface/plugins/Tauolapp/TauolappInterface.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @inugent for CMSSW_7_1_X.

Backport evtgen photospp to7 1 x

It involves the following packages:

GeneratorInterface/EvtGenInterface
GeneratorInterface/ExternalDecays
GeneratorInterface/PhotosInterface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 25f91ec
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/EvtGenInterface/src/EvtGenInterfaceBase.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/EvtGenInterface/plugins/DataCardFileWriter.cc 
Entering library rule at src/GeneratorInterface/EvtGenInterface/plugins
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/EvtGenInterface/plugins/myEvtRandomEngine.cc:18:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/EvtGenInterface/interface/myEvtRandomEngine.h:21:41: fatal error: EvtGenBase/EvtRandomEngine.hh: No such file or directory
 #include "EvtGenBase/EvtRandomEngine.hh"
                                         ^
compilation terminated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/PhotosInterface/src/PhotosFactory.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-08-18-0200/src/GeneratorInterface/EvtGenInterface/plugins/myEvtRandomEngine.cc:18:0:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4970/1886/summary.html

@inugent
Copy link
Contributor Author

inugent commented Sep 3, 2014

This test failed because it depends on cmsdist pull request #916. This pull request was made at the request of Vitallianto and Josh so they could be handled while I was away. Please freeze this request until cmsdist pull request is merged 916.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it?

@ghost
Copy link

ghost commented Sep 17, 2014

+1
Tested against #1019.

@davidlange6
Copy link
Contributor

Perhaps we can eventually rethink the idea of a perl script to covert some format to python?

@davidlange6
Copy link
Contributor

+1

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants