Revert broken tau fixes (72x)

[bendavid]

Reverts recent sets of changes to Tauola++ interface which caused undecayed taus in rare cases and therefore crashes in the validation sequence.

This reverts pull requests:
#4834
#4932

[cmsbuild]

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_2_X.

Revert broken tau fixes (72x)

It involves the following packages:

GeneratorInterface/TauolaInterface
Validation/EventGenerator

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
@inugent this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[bendavid]

@inugent fyi

[bendavid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[davidlange6]

@bendavid - do you have a way to test that things are now ~ok on the 10000 event level now? (e.g., gen+edanalyzer) - hoping for positive verification that the bug is fixed this time around..

[cmsbuild]

+1
Tested at: 1343f76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4986/640/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[bendavid]

@davidlange6, working on it. (Will run GEN plus the gen validation sequence on one of the failing relvals.)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4986/640/summary.html

[bendavid]

I'm unfortunately not able to reproduce even the original crash in pre3 using GEN plus VALIDATION:genvalid_all, will try to understand why...

[inugent]

Hello,
I am not sure if this is helpful, but the example I was given last week was a slhc sequence. When I ran only the gen fragment without the slhc config it ran over 100k events. Is it still only a slhc sample that crashes? Could this be a problem with slhc config only? It is possible to break tauola if you use the wrong setup in cmssw. Or is this a general problem with all samples?
Best regards,
Ian

Sent from my iPhone

On Aug 19, 2014, at 12:08 PM, Josh Bendavid notifications@github.com wrote:

I'm unfortunately not able to reproduce even the original crash in pre3 using GEN plus VALIDATION:genvalid_all, will try to understand why...

—
Reply to this email directly or view it on GitHub.