Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced any TMatrix and TVector by SMatrix and SVector in MET significance code #5416

Closed
wants to merge 29 commits into from
Closed

Replaced any TMatrix and TVector by SMatrix and SVector in MET significance code #5416

wants to merge 29 commits into from

Conversation

mmarionncern
Copy link

Removed any instance of TMatrix and TVector in benefit to SMatrix and SVector in the MET significance code and MET code, used to keep the covariance matrix.
An extra typedef has been declared in DataFormat/METReco/interface/MET.h to standardize the definition of the MET covariance matrix.

This PR is necessary to complete the PR #5388

Volker Adler and others added 26 commits September 17, 2014 15:49
Resolve potential division by 0 in print out.
3637361
@deguio
fix uninitialized variable
258aaa4
Fix file path.
fc00a64
@danduggan
fixing info summary plot for online running
9258388
@danduggan
fixing info summary plot for online running
d1a16e7
@davidlange6
Merge pull request cms-sw#5344 from vadler/72X-fixDivisionByZero
5f9b6ca 
72X - fix division by zero
@ktf
Merge pull request cms-sw#5351 from cms-sw/CMSSW_7_2_X
32d4f50 
Forward port CMSSW_7_2_X into CMSSW_7_3_X
@davidlange6
Merge pull request cms-sw#5385 from smorovic/output-checksum-72X
192d30c 
output adler32 checksumming propagated to JSON file
@davidlange6
Merge pull request cms-sw#5382 from mtosi/from-CMSSW_7_2_0_pre5_fixTr…
dd05829 
…ackingSummaryMap

DQM: fix tracking summary map
@davidlange6
Merge pull request cms-sw#5358 from alja/72tarball
67bf335 
72x changes related to cmsShow standalone version
@davidlange6
Merge pull request cms-sw#5360 from deguio/fixUninitVar_SiPixelTrackR…
a96948b 
…esidualSource

fix uninitialized variable
@davidlange6
Merge pull request cms-sw#5363 from davidlt/PixelChannelIdentifier-ub…
bdaf052 
…san-clean

Clean up undefined behavior in PixelChannelIdentifier.h
@davidlange6
Merge pull request cms-sw#5365 from alja/72xWarr
74e91b1 
72x Fix gcc491 warning.
@davidlange6
Merge pull request cms-sw#5369 from Dr15Jones/staticAnalyzerFixDataFo…
08b8b1a 
…rmatsL1Trigger

Silence static analyzer warning for BXVector
@davidlange6
Merge pull request cms-sw#5376 from Dr15Jones/clangFixRecoEgammaElect…
79db425 
…ronIdentification

Clang fixes for RecoEgamma/ElectronIdentification
@davidlange6
Merge pull request cms-sw#5377 from Dr15Jones/clangFixPhysicsToolsSel…
f08cac4 
…ectorUtils

Clang fixes for PhysicsTools/SelectorUtils
@davidlange6
Merge pull request cms-sw#5373 from fwyzard/FastTimerServiceClient_up…
6da1d25 
…date_interface_72x

FastTimerServiceClient: update plots after every lumisection
@davidlange6
Merge pull request cms-sw#5375 from Dr15Jones/clangFixL1TriggerL1TCal…
45cf424 
…orimeter

Fixed clang compiler warnings and errors
@davidlange6
Merge pull request cms-sw#5361 from ianna/dd-tests-cleanup
dda5322 
DD Tests Cleanup
@davidlange6
Merge pull request cms-sw#5362 from davidlt/from-CMSSW_7_2_X_2014-09-…
e50a879 
…17-0200

FWCore: add support for Address Sanitizer IBs
@davidlange6
Merge pull request cms-sw#5371 from fwyzard/chrono_fix_IFUNC_for_clang
6d68278 
chrono: improvements to IFUNC and native timers
@davidlange6
Merge pull request cms-sw#5348 from danduggan/infofix73x
668f97f 
 DQM info summary fix for online LS reporting in 73x
@davidlange6
Merge pull request cms-sw#5355 from danduggan/infofix72x
bca3c75 
DQM info summary fix for online LS reporting in 72x
@davidlange6
Merge pull request cms-sw#5334 from deguio/fixUninitVar_SiPixelTrackR…
f8a432f 
…esidualSource_73x

fix uninitialized variable
Replaced any TMatrix and TVector by SMatrix and SVector in MET signif…
646855b 
…icance code
comments cleaning
6906d27
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 18, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_2_X.

Replaced any TMatrix and TVector by SMatrix and SVector in MET significance code

It involves the following packages:

DataFormats/METReco
RecoMET/METAlgorithms

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@mmarionncern this should go to 73X. You quote #5388 which is 73X.

@mmarionncern
Copy link
Author

My mistake, I close that one and open a new one in 73X.

@mmarionncern
Copy link
Author

Following #5417
It seems that offline is pushing as well for the integration in 72X.

@mmarionncern mmarionncern reopened this Sep 19, 2014
@cmsbuild
Copy link
Contributor

Pull request #5416 was updated. @nclopezo, @StoyanStoynev, @danduggan, @rovere, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @ojeda can you please check and sign again.

@StoyanStoynev
Copy link
Contributor

Is it up to date with #5417 now? I see the line (and files!) changes are different, can you clarify.

@mmarionncern
Copy link
Author

Something is going wrong... there are changes which are not mine. MET changes in #5417 and #5416 are identical but htere is a lot of stuff which should not be there.
Investigation ongoing...

@mmarionncern
Copy link
Author

It seems that is related to the rebase used for 73X in the 72X_METMatrixChange branch. I will restart from scratch to avoid a potential conflict, if it is fine to everyone.

@StoyanStoynev
Copy link
Contributor

ok

@mmarionncern mmarionncern mentioned this pull request Sep 19, 2014
Merged
@mmarionncern mmarionncern deleted the 72X_METMatrixChange branch November 14, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending dqm-pending pending-signatures reconstruction-pending tests-pending
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mmarionncern @cmsbuild @StoyanStoynev @deguio @danduggan @davidlange6 @ktf