New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused seedsRefs from DuplicateListMerger.cc #5451
Conversation
RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc:196:49 was reported by UBSan 25 times during full matrix. DuplicateListMerger.cc:196:49: runtime error: variable length array bound evaluates to non-positive value 0 Example workflows: - 33.0 / step3 - 1319.0 / step3 - 1001.0 / step2 - 1002.0 / step2 seedsRefs is not used and removing it does not trigger any side effects. Otherwise this is a potential spot for out-of-bounds writes to stack if a possible code path if found. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_2_X. Remove unsued seedsRefs from DuplicateListMerger.cc It involves the following packages: RecoTracker/FinalTrackSelectors @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
Remove unused seedsRefs from DuplicateListMerger.cc
RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc:196:49
was reported by UBSan 25 times during full matrix.
Example workflows:
seedsRefs
is not used and removing it does not trigger any side effects.Otherwise this is a potential spot for out-of-bounds writes to stack if
a possible code path if found.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch