Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused seedsRefs from DuplicateListMerger.cc #5451

Merged
merged 1 commit into from Sep 23, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Sep 20, 2014

RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc:196:49
was reported by UBSan 25 times during full matrix.

DuplicateListMerger.cc:196:49: runtime error: variable length array
bound evaluates to non-positive value 0

Example workflows:

  • 33.0 / step3
  • 1319.0 / step3
  • 1001.0 / step2
  • 1002.0 / step2

seedsRefs is not used and removing it does not trigger any side effects.
Otherwise this is a potential spot for out-of-bounds writes to stack if
a possible code path if found.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc:196:49
was reported by UBSan 25 times during full matrix.

DuplicateListMerger.cc:196:49: runtime error: variable length array
bound evaluates to non-positive value 0

Example workflows:
- 33.0 / step3
- 1319.0 / step3
- 1001.0 / step2
- 1002.0 / step2

seedsRefs is not used and removing it does not trigger any side effects.
Otherwise this is a potential spot for out-of-bounds writes to stack if
a possible code path if found.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_2_X.

Remove unsued seedsRefs from DuplicateListMerger.cc

It involves the following packages:

RecoTracker/FinalTrackSelectors

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@VinInn
Copy link
Contributor

VinInn commented Sep 20, 2014

+1

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 467b7fa . Based on jenkinsa - no diffs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@davidlt davidlt changed the title Remove unsued seedsRefs from DuplicateListMerger.cc Remove unused seedsRefs from DuplicateListMerger.cc Sep 21, 2014
davidlange6 added a commit that referenced this pull request Sep 23, 2014
Remove unused seedsRefs from DuplicateListMerger.cc
@davidlange6 davidlange6 merged commit e0ac35a into cms-sw:CMSSW_7_2_X Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants