Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused seedsRefs from DuplicateListMerger.cc #5451

Merged
merged 1 commit into from Sep 23, 2014
Merged

Remove unused seedsRefs from DuplicateListMerger.cc #5451

merged 1 commit into from Sep 23, 2014

Commits on Sep 20, 2014

  1. Remove unsued seedsRefs from DuplicateListMerger.cc 

    RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc:196:49
was reported by UBSan 25 times during full matrix.

DuplicateListMerger.cc:196:49: runtime error: variable length array
bound evaluates to non-positive value 0

Example workflows:
- 33.0 / step3
- 1319.0 / step3
- 1001.0 / step2
- 1002.0 / step2

seedsRefs is not used and removing it does not trigger any side effects.
Otherwise this is a potential spot for out-of-bounds writes to stack if
a possible code path if found.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Sep 20, 2014
    Copy the full SHA
    467b7fa View commit details
    Browse the repository at this point in the history