Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of fixes requested by David A. #5543

Merged
merged 3 commits into from Sep 25, 2014

Conversation

dmitrijus
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_3_X.

A couple of fixes requested by David A.

It involves the following packages:

DQMOffline/L1Trigger
Validation/RecoTrack

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda, @mulhearn can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @cerati, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

+1

@deguio
Copy link
Contributor

deguio commented Sep 24, 2014

+1
@davidlt see also #5538
the three issues you mentioned should be all solved now.
ciao,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Sep 25, 2014
DQM -- A couple of fixes requested by David A.
@nclopezo nclopezo merged commit 72cb792 into cms-sw:CMSSW_7_3_X Sep 25, 2014
@VinInn
Copy link
Contributor

VinInn commented Sep 25, 2014

-3!

@slava77
Copy link
Contributor

slava77 commented Sep 25, 2014

We need to add an optional performance-veto label, maybe?

@ktf
Copy link
Contributor

ktf commented Sep 25, 2014

Can do that. If you have a list of critical packages, I can add usual suspects to it. @davidlange6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants