MiniAOD for InputGenJetsParticleSelector #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort for miniAOD Conflicts: RecoJets/JetProducers/plugins/InputGenJetsParticleSelector.cc
… prevent double-counting
|
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_2_X. MiniAOD for InputGenJetsParticleSelector It involves the following packages: RecoJets/JetProducers @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
-1 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 08-Oct-2014 11:35:59 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'prevalidation_step'
[2] Calling event method for module TauValGenPRefSelector/'kinematicSelectedTauValDenominatorZEE'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::RefVector,reco::GenParticle,edm::refhelper::FindUsingAdvance,reco::GenParticle> >
Looking for module label: selectStableElectrons
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 08-Oct-2014 11:42:48 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'prevalidation_step'
[2] Calling event method for module TauValGenPRefSelector/'kinematicSelectedTauValDenominatorZEE'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::RefVector,reco::GenParticle,edm::refhelper::FindUsingAdvance,reco::GenParticle> >
Looking for module label: selectStableElectrons
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
9.0 step3 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 08-Oct-2014 11:42:48 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'prevalidation_step'
[2] Calling event method for module TauValGenPRefSelector/'kinematicSelectedTauValDenominatorZEE'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::RefVector,reco::GenParticle,edm::refhelper::FindUsingAdvance,reco::GenParticle> >
Looking for module label: selectStableElectrons
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 08-Oct-2014 11:46:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'prevalidation_step'
[2] Calling event method for module TauValGenPRefSelector/'kinematicSelectedTauValDenominatorZEE'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::RefVector,reco::GenParticle,edm::refhelper::FindUsingAdvance,reco::GenParticle> >
Looking for module label: selectStableElectrons
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
you can see the results of the tests here: |
|
The updated selector code is now fully Candidate-based and no longer uses the GenParticle class. @jpavel, can the tau validation workflow be adapted to the updated selector code? |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
davidlange6
added a commit
that referenced
this pull request
Oct 15, 2014
…Selector_from-CMSSW_7_2_0_pre7 MiniAOD for InputGenJetsParticleSelector
ferencek
deleted the
MiniAODForInputGenJetsParticleSelector_from-CMSSW_7_2_0_pre7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the InputGenJetsParticleSelector so it also works with miniAOD. The main difference between AOD and miniAOD is that in miniAOD a subset of GenParticles is stored in the following two collections:
prunedGenParticlespackedGenParticlesand InputGenJetsParticleSelector needs to access both collections in order to perform the same selection of GenParticles as in AOD where all GenParticles are stored in one collection,
genParticles. Attached are a few comparison plots. Small differences between AOD and miniAOD are expected due to the loss of precision in the GenParticle (un)packing process.