Remove CurrentProcessingContext from HLTrigger #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all uses of CurrentProcessingContext from HLTrigger packages. This is replaced by using the new ModuleCallingContext. There should be no change in behavior. The only interface change in the HLTrigger code is that the Event is an added argument to some functions. These functions are only used in a few places and all uses are fixed. Also in the Framework, the PlaceInPathContext class is added and used. Removed the unused filling of TriggerResults for end paths. Some other minor Framework cleanup and unit tests.
|
@Dr15Jones @Martin-Grunewald @perrotta can you please sign? |
ghost
assigned 
|
I wanted to wait for the results of the run the tests before signing. |
|
The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT @cms-git-hlt, @cms-git-fastsim |
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
|
Hi, I took these changes on top of CMSSW_7_0_X_2013-08-21-0200, I ran the unit tests and RelVals, all tests passed. You can see the logs here: |
ktf
added a commit
that referenced
this pull request
Aug 22, 2013
…mHLT Remove CurrentProcessingContext from HLTrigger
jbsauvan
pushed a commit
to jbsauvan/cmssw
that referenced
this pull request
Jan 26, 2016
…7_4_12_samples3 fix QCD Mu5 samples in mAOD v2
veelken
pushed a commit
to veelken/cmssw
that referenced
this pull request
Dec 21, 2016
…py80X_MDG add Triggers for entire 2016
fwyzard
pushed a commit
to fwyzard/cmssw
that referenced
this pull request
Nov 23, 2020
Update GPU code following cms-sw#32146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all uses of CurrentProcessingContext from HLTrigger
packages. This is replaced by using the new ModuleCallingContext.
There should be no change in behavior. The only interface change
in the HLTrigger code is that the Event is an added argument
to some functions. These functions are only used in a few
places and all uses are fixed. Also in the Framework, the
PlaceInPathContext class is added and used. Removed the unused
filling of TriggerResults for end paths. Some other minor
Framework cleanup and unit tests.