Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FED id for pixels #5816

Merged
merged 3 commits into from Oct 16, 2014
Merged

Extend FED id for pixels #5816

merged 3 commits into from Oct 16, 2014

Conversation

dkotlins
Copy link
Contributor

This pull request has two components:

  1. Extend the maximum FED id for raw data for pixels from 29 to 40 to accommodate the pilot blade fed.
  2. Extend the PixelNames functionality to cover the new pilot blade and the phase 1 pixels.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dkotlins for CMSSW_7_3_X.

Extend FED id for pixels

It involves the following packages:

DataFormats/FEDRawData
DataFormats/SiPixelDetId

@civanch, @nclopezo, @emeschi, @mdhildreth, @cmsbuild, @mommsen can you please review it and eventually sign? Thanks.
@makortel, @venturia, @VinInn, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Oct 14, 2014

+1
Checked with Attila Racz that FED id 40 can be used for pixel pilot blade.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Oct 15, 2014

@cmsbuild, I do not see comparison results even if it is green

@nclopezo
Copy link
Contributor

Hi Vladimir,

For this PR they are here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/5816/4290/

@civanch
Copy link
Contributor

civanch commented Oct 15, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 16, 2014
DataFormats -- Extend FED id for pixels
@nclopezo nclopezo merged commit 0dc5fca into cms-sw:CMSSW_7_3_X Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants