Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation code for BTagging at HLT #5904

Merged
merged 37 commits into from Nov 7, 2014
Merged

Conversation

silviodonato
Copy link
Contributor

Re-ope of PR #5387

It is a validation code for the b-tagging at HLT.
It was presented in the DQM meeting : https://indico.cern.ch/event/294162/

News:

  • implemented comments by @deguio
  • integration of the validation in the central validation sequence (added in hltValidation of HLTriggerOffline/Common)
  • tested with "python whiteRabbit.py" Align documentation to migrated repository. #3 and Test feature #4 , with small changes:
    • I'm using TTbar, instead of SingleMu, in order to have few jets, needed for b-tagging.
    • I'm also using the HLT:FULL menu, as it always run b-tagging (if you think the code has to use HLT:GRun, I can change quickly the code).
  • Although I propose to add the code in the central validation sequence, I'd like to maintain the code used for a private b-tag validation (config.ini, test.py, .....)

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 21, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

@deguio
Copy link
Contributor

deguio commented Nov 7, 2014

+1
thanks @silviodonato

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 7, 2014
Validation code for BTagging at HLT
@cmsbuild cmsbuild merged commit f47d7df into cms-sw:CMSSW_7_3_X Nov 7, 2014
@davidlange6
Copy link
Contributor

Reverting this so that the IBs will be more successful. Please resubmit when fixed.

@silviodonato
Copy link
Contributor Author

Hi,
I've corrected the code: https://github.com/silviodonato/cmssw/tree/btag-hlt

In very few events it happened that HLT_PFMET170_NoiseCleaned_v1 pass, but no b-tag variables were reconstructed (although HLT_PFMET120_NoiseCleaned_BTagCSV07_v1 use lower threshold).
This because HLT_PFMET120_NoiseCleaned_BTagCSV07 use also a cut on "hltMETCleanUsingJetID80".

Now, I select only events that pass HLT_PFMET120_NoiseCleaned_BTagCSV07, so we have BTag variables for sure.

Do I need to ask a new PR?

Thanks,
Silvio.

@nclopezo
Copy link
Contributor

@silviodonato
Hi Silvio,
Yes, you should create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants