Calibration Packages -- changes for large object passed by value

[gartung]

found by clang static analyzer cms.ArgSizeChecker

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

Calibration Packages -- changes for large object passed by value

It involves the following packages:

CalibTracker/SiStripQuality
Calibration/EcalCalibAlgos
CalibCalorimetry/HcalAlgos
CalibTracker/SiStripDCS
CalibCalorimetry/HcalPlugins
CalibFormats/SiPixelObjects
Calibration/HcalCalibAlgos
CalibCalorimetry/EcalTPGTools

@demattia, @rcastello can you please review it and eventually sign? Thanks.

[cmsbuild]

Pull request #600 was updated. Signatures reset, please check and sign again.

[demattia]

I guess if the passed objects were modified internally the code would not compile when moving to a const reference.
The changes look fine to me, but since they touch several files, would it be possible to have a round of tests?

[nclopezo]

Hi,

It is being tested here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/267/console

[nclopezo]

The tests finished without errors. The artifacts can be seen here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/267/

[demattia]

+1
Perfect, thank you for the tests.

[ktf]

@mulhearn can you please look at this?

[ktf]

@mulhearn can you please look at this?

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?