Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor hlt filters for run2 development in 72X #6056

Merged
merged 2 commits into from Nov 7, 2014

Conversation

jmduarte
Copy link
Member

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jmduarte (Javier Duarte) for CMSSW_7_2_X.

Razor hlt filters for run2 development in 72X

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

edm::Ref<reco::METCollection> mrRsqRef(ref_before_put, 0);

//add it to the trigger object collection
filterproduct.addCollectionTag(edm::InputTag( *moduleLabel()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filterproduct.addCollectionTag(edm::InputTag( *moduleLabel()));

should only be done if saveTags() is true ! Please add the if clause,
ie, something like

 if (saveTags()) filterproduct.addCollectionTag(edm::InputTag( *moduleLabel()));

(in both PRs, ie, for 72X and 73X)

@Martin-Grunewald
Copy link
Contributor

-1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants