Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF cluster isolation for muons + TimeCleaned RecHit producer. #6266

Merged
merged 16 commits into from Nov 14, 2014

Conversation

HuguesBrun
Copy link
Contributor

This PR will add the producers and filters to have the PF cluster isolation on muons at HLT.
The EgammaHLTEcal[Hcal]PFClusterIsolationProducer.cc are replaced by a template HLTEcal[Hcal]PFClusterIsolationProducer.cc thanks to @matteosan1.
In HLTEcal[Hcal]PFClusterIsolationProducer.cc, the parameters recoEcalCandidateProducer is replaced by recoCandidateProducer: @Martin-Grunewald and @perrotta, will it cause a problem ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_3_X.

PF cluster isolation for muons + TimeCleaned RecHit producer.

It involves the following packages:

DataFormats/RecoCandidate
HLTrigger/Muon
RecoEgamma/EgammaHLTProducers
RecoMuon/L3MuonIsolationProducer

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @lgray, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -0,0 +1,55 @@
#ifndef HLTMuonGenericFilter_h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a verbatim copy of the HLTElectronGenericFilter.
Thus is is better to make that filter templated and
instantiate two instances, one for the Electrons, one for the Muons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin,
You are right, I will do that

@Martin-Grunewald
Copy link
Contributor

-1
No code duplications!

@Martin-Grunewald
Copy link
Contributor

Yes as it will require a concurrent migration of the HLT menus.

There are five instances of PFClusterIsolationProducers in the
HLT menu, I assume the migration is just moving the InputTag
value from the old recoEcalCandidateProducer parameter to the new
recoCandidateProducer parameter?

@HuguesBrun
Copy link
Contributor Author

yes exactly.

#include <vector>

namespace reco {
typedef edm::AssociationMap<edm::OneToValue<std::vector<reco::RecoChargedCandidate>, float > > RecoChargedCandidateIsolationMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(need to understand if AssoMap is needed; comments on the producer to follow)

@slava77
Copy link
Contributor

slava77 commented Nov 7, 2014

I will not make any further review until the -1 from HLT is cleared

@slava77
Copy link
Contributor

slava77 commented Nov 10, 2014

-1

to take of our list, since the pending action item raised by Martin

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2014

+1

for #6266 dc29ac0
tested in CMSSW_7_3_X_2014-11-14-0200 (test area sign456).
Tests included only the jenkins-like brief versions, which were showing issues in HLT values before.
There are no diffs in performance anymore.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
PF cluster isolation for muons + TimeCleaned RecHit producer.
@cmsbuild cmsbuild merged commit c1df6e1 into cms-sw:CMSSW_7_3_X Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants