New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF cluster isolation for muons + TimeCleaned RecHit producer. #6266
Conversation
A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_3_X. PF cluster isolation for muons + TimeCleaned RecHit producer. It involves the following packages: DataFormats/RecoCandidate @perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@@ -0,0 +1,55 @@ | |||
#ifndef HLTMuonGenericFilter_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a verbatim copy of the HLTElectronGenericFilter.
Thus is is better to make that filter templated and
instantiate two instances, one for the Electrons, one for the Muons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Martin,
You are right, I will do that
-1 |
Yes as it will require a concurrent migration of the HLT menus. There are five instances of PFClusterIsolationProducers in the |
yes exactly. |
#include <vector> | ||
|
||
namespace reco { | ||
typedef edm::AssociationMap<edm::OneToValue<std::vector<reco::RecoChargedCandidate>, float > > RecoChargedCandidateIsolationMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(need to understand if AssoMap is needed; comments on the producer to follow)
I will not make any further review until the -1 from HLT is cleared |
-1 to take of our list, since the pending action item raised by Martin |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
PF cluster isolation for muons + TimeCleaned RecHit producer.
This PR will add the producers and filters to have the PF cluster isolation on muons at HLT.
The
EgammaHLTEcal[Hcal]PFClusterIsolationProducer.cc
are replaced by a templateHLTEcal[Hcal]PFClusterIsolationProducer.cc
thanks to @matteosan1.In
HLTEcal[Hcal]PFClusterIsolationProducer.cc
, the parametersrecoEcalCandidateProducer
is replaced byrecoCandidateProducer
: @Martin-Grunewald and @perrotta, will it cause a problem ?