Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DQM/HLTEvF based on Clang warnings/errors #6359

Merged
merged 3 commits into from Nov 13, 2014

Commits on Nov 12, 2014

  1. Resolve unused variable 'SECS_PER_LUMI' error

    Clang 3.5.0 complains regarding unused variable:
    
        DQM/HLTEvF/plugins/TriggerRatesMonitor.cc:44:21: error: unused variable
        'SECS_PER_LUMI' [-Werror,-Wunused-const-variable]
    
    The patch removes it.
    
    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Nov 12, 2014
    Copy the full SHA
    22509f5 View commit details
    Browse the repository at this point in the history
  2. Resolve all -Wunused-private-field warnings

    A vast number of warnings in `DQM/HLTEvF` are
    
        private field '???' is not used [-Wunused-private-field]
    
    It looks like a mistake of copy & paste. The patch removes all such
    not needed private fields.
    
    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Nov 12, 2014
    Copy the full SHA
    82c0ec2 View commit details
    Browse the repository at this point in the history
  3. std::fabs ==> std::abs if argument is int

    We have `std::vector<int>`, thus std::abs must be used from `<cstdlib>`.
    Otherwise it triggers unnecessary conversion to `double`.
    
    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Nov 12, 2014
    Copy the full SHA
    5ff99b2 View commit details
    Browse the repository at this point in the history