bugfix for pixel clustershape filter, and, change HI tracking low-pt seeding from triplet to track

[yetkinyilmaz]

As listed in the commits, first commit is for bugfixing the clustershape filter, removing conflict between two vs three argument version of the operator(). This was a prerequisite for the update of low-pt tracking.

In the second commit, the HI tracking uses tracks instead of triplets in seeding, which is a significant improvement in timing. Details in: https://indico.cern.ch/event/345510/contribution/5/material/slides/0.pdf

This PR requires #6374 to be merged, in order to run the full HI reco sequence successfully.

[cmsbuild]

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_3_X.

bugfix for pixel clustershape filter, and, change HI tracking low-pt seeding from triplet to track

It involves the following packages:

RecoHI/HiTracking
RecoPixelVertexing/PixelTrackFitting

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@echapon, @makortel, @GiacomoSguazzoni, @jazzitup, @VinInn, @appeltel, @richard-cms, @yenjie, @rovere, @kurtejung, @cerati, @mandrenguyen, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[rovere]

maybe forward declare it?

[slava77]

@cerati @rovere @VinInn
The change looks simple, still, please check and say if it's OK.
Thanks.

[rovere]

Ciao Slava,
looks ok to me.

M.

[makortel]

Should also the value of useClusterShape parameter be checked (in addition of its existence)?

[mandrenguyen]

No, this is just tells you whether the class inherits from
clusterShapeTrackFilter or not.
If it does, it should use the 3 parameter version of the operator(),
whether or not the parameter is set to True.
There is certainly a more elegant solution, but this was the minimally
invasive approach.

On 11/13/14 3:52 PM, Matti Kortelainen wrote:

In RecoPixelVertexing/PixelTrackFitting/src/PixelTrackReconstruction.cc:

@@ -56,6 +56,7 @@ PixelTrackReconstruction::PixelTrackReconstruction(const ParameterSet& cfg,
if(theConfig.exists("useFilterWithES")) {
edm::LogInfo("Obsolete") << "useFilterWithES parameter is obsolete and can be removed";
}

• useClusterShape = filterPSet.exists("useClusterShape");

Should also the value of useClusterShape parameter be checked (in
addition of its existence)?

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/6376/files#r20295348.

---

Matthew Nguyen
Chargé de Recherche
LLR-Ecole Polytechnique
91128 Palaiseau FRANCE

+33 1 69 33 55 65

[makortel]

Ah, right, and the filter itself checks the value. Got it, thanks.

[cmsbuild]

+1
Tested at: f7013cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376/862/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376/862/summary.html

[slava77]

testing ... together with #6374.
It would've been more practical in this case to have #6376 to include #6374 , since #6374 is fairly trivial.

[cmsbuild]

+1
Tested at: f7013cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376/882/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376/882/summary.html

[slava77]

+1

for #6376 f7013cc
CMSSW_7_3_X_2014-11-13-1400 (test area sign461)

Here is a brief summary of what I see from a combination of #6374 and this PR on top of CMSSW_7_3_X_2014-11-13-1400.

In general, the changes are in the expected direction:
(the plots are all based on 140.53, 400 events, 182124:40 from UPC)

• initialStep tracks now show up
  
• more tracks in the central
  
• the number of muons increases, but most of them are probably fakes
  • the rate of global muons is about the same
    the trkKink plotted points to more tracks with inflections along the trajectory
    
• large increase in particleFlowEGamma in the barrel
  
  
• most of these changes in upstream objects are not making it through as visible post-PF changes
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.