Pass address of pointer, not value of pointer #6521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes ROOT 6 specific segfaults in four unit tests in CondCore packages, although the tests still fail later due to a different problem.
In two places in the code, the address of a pointer to an object needed to be passed to an ObjectWithDict constructor.
Unfortunately, the value of the pointer was passed instead (missing '&').
Editorial comment: I hate code that is not type safe.
This request also does some minor optimization by avoiding unnecessary ObjectWithDict::typeOf() calls, since the return value is already known.
Please merge this request as soon as convenient.