Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass address of pointer, not value of pointer #6521

Merged
merged 1 commit into from Nov 21, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 21, 2014

This request fixes ROOT 6 specific segfaults in four unit tests in CondCore packages, although the tests still fail later due to a different problem.
In two places in the code, the address of a pointer to an object needed to be passed to an ObjectWithDict constructor.
Unfortunately, the value of the pointer was passed instead (missing '&').
Editorial comment: I hate code that is not type safe.
This request also does some minor optimization by avoiding unnecessary ObjectWithDict::typeOf() calls, since the return value is already known.
Please merge this request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

Pass address of pointer, not value pf pointer

It involves the following packages:

CondCore/ORA

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Nov 21, 2014
Pass address of pointer, not value pf pointer
@davidlt davidlt merged commit 805da19 into cms-sw:CMSSW_7_3_ROOT6_X Nov 21, 2014
@apfeiffer1
Copy link
Contributor

+1

@wmtan wmtan changed the title Pass address of pointer, not value pf pointer Pass address of pointer, not value of pointer Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants