Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM protobuf reads and writes now close the file descriptors properly. #6570

Merged
merged 2 commits into from Nov 24, 2014

Conversation

dmitrijus
Copy link
Contributor

Well, not properly, this is just a quick fix.
We should rewrite and avoid using ::open altogether.

Well, not properly, this is just a quick fix.
We should rewrite and avoid using ::open altogether.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_2_X.

DQM protobuf reads and writes now close the file descriptors properly.

It involves the following packages:

DQMServices/Components
DQMServices/Core

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Nov 24, 2014

+1
fine to go with this fix for now.
@rovere

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Nov 24, 2014

another commit is needed and would like this PR to be tested.
F.

@dmitrijus
Copy link
Contributor Author

I've added the commit which fixes the error.

@cmsbuild
Copy link
Contributor

Pull request #6570 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Nov 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 24, 2014
DQM protobuf reads and writes now close the file descriptors properly.
@davidlange6 davidlange6 merged commit e7c16bd into cms-sw:CMSSW_7_2_X Nov 24, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild added a commit that referenced this pull request Dec 4, 2014
cmsbuild added a commit that referenced this pull request Jan 6, 2015
Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display (#6637).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants