New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM protobuf reads and writes now close the file descriptors properly. #6570
DQM protobuf reads and writes now close the file descriptors properly. #6570
Conversation
Well, not properly, this is just a quick fix. We should rewrite and avoid using ::open altogether.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_2_X. DQM protobuf reads and writes now close the file descriptors properly. It involves the following packages: DQMServices/Components @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
another commit is needed and would like this PR to be tested. |
I've added the commit which fixes the error. |
Pull request #6570 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
DQM protobuf reads and writes now close the file descriptors properly.
Well, not properly, this is just a quick fix.
We should rewrite and avoid using ::open altogether.