Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT migration to TrackClusterRemover (from HLTTrackClusterRemoverNew) #6618

Merged
merged 8 commits into from Dec 5, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

HLT migration to TrackClusterRemover (from HLTTrackClusterRemoverNew)
This PR requires and thus contains these PRs: #6535 #6568 #6595 #6599 .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_3_X.

HLT migration to TrackClusterRemover (from HLTTrackClusterRemoverNew)

It involves the following packages:

HLTrigger/Configuration
RecoHI/HiEgammaAlgos
RecoLocalTracker/SubCollectionProducers
RecoParticleFlow/PFTracking
RecoTracker/ConversionSeedGenerators
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @forthommel, @yduhm, @nickmccoll, @lgray, @threus, @geoff-smith, @venturia, @mmarionncern, @makortel, @richard-cms, @jlagram, @cerati, @mandrenguyen, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @jalimena, @dgulhan, @gbenelli, @jazzitup, @appeltel, @yenjie, @kurtejung, @gpetruc, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Nov 26, 2014

Can you please merge the required PRs into this one? Otherwise tests will fail.

@Martin-Grunewald
Copy link
Contributor Author

I did that and they are there! The tests (well, my tests :) run fine with just this PR on top of CMSSW_7_3_X_2014-11-25-1400. [Presumably the PRs are not shown in the list of commits
because I had rebased all together to CMSSW_7_3_X_2014-11-25-0200 before making the PR]

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants