Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to multithread friendly modules #6686

Merged
merged 11 commits into from Dec 5, 2014

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Nov 28, 2014

In this pull request modules used by HLT paths with taus are migrated to multithread friendly modules - in most to edm::global::EDProducer.
In addition const data members of many of the modules explicitely defined as const.
The pull request should be also forwardported to 74X release series.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_7_3_X.

Migration to multithread friendly modules

It involves the following packages:

HLTrigger/btau
RecoTauTag/HLTProducers
RecoTauTag/TauTagTools

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @jpavel, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 28, 2014

+1

for #6686 d15891c

based on tests in for #6687 8a8b639
which is identical to this

@slava77
Copy link
Contributor

slava77 commented Dec 5, 2014

+1

for #6686 1914235
based on jenkins tests (no differences observed)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants