New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to multithread friendly modules #6687
Migration to multithread friendly modules #6687
Conversation
A new Pull Request was created by @mbluj for CMSSW_7_4_X. Migration to multithread friendly modules It involves the following packages: HLTrigger/btau @perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
why is this one different from #6686? (the number of diffs according to github web is +129 −147 compared to +111 −129). |
nm, it's actually the same. |
+1 for #6687 8a8b639 tested in CMSSW_7_4_X_2014-11-27-0200 ( test area sign469, in combination with PRs 6658-6659-6662-6670-6671-6687) checked with a short matrix: no diffs in reco, no diffs in 5.1 and 25.0 short matrix DQM outputs |
edm::EDGetTokenT<trigger::TriggerFilterObjectWithRefs> triggerFilterMuonsSrc; | ||
edm::EDGetTokenT<edm::View<reco::Vertex> > vertexLabel; | ||
edm::EDGetTokenT<reco::BeamSpot> beamSpotLabel; | ||
const edm::ParameterSet config() const { return theConfig; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a const & to avoid making a copy.
Oh, nice. On 11/28/14, 5:33 PM, Chris Jones wrote:
Vyacheslav (Slava) Krutelyov |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Migration to multithread friendly modules
Dear Chris, thank you for your detailed cheks of the code. I will follow your suggestions and then prepare a new PR. |
In this pull request modules used by HLT paths with taus are migrated to multithread friendly modules - most of them to to edm::global::EDProducer.
This is a forward-port of #6686 to 74X release series.