New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important BUG FIX in parameter assignment of millepede-based tracker alignment #6726
Important BUG FIX in parameter assignment of millepede-based tracker alignment #6726
Conversation
A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_2_X. Important BUG FIX in parameter assignment of millepede-based tracker alignment It involves the following packages: Alignment/CommonAlignmentAlgorithm @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
…Members-72X Important BUG FIX in parameter assignment of millepede-based tracker alignment
The bug corrupts the IOV-dependent alignment in releases compiled with
slc6_amd64_gcc472 and later. It is caused by using a dangling reference to
an edm::EventID object to determine the run number. At least with the gcc
versions in SLC6, this results in an incorrect determination of the current
IOV. Details are given in this presentation at the tracker-alignment meeting:
https://indico.cern.ch/event/342234/session/0/contribution/8/0/material/slides/0.pdf
The implementation is the outcome of a discussion of #6515 .
This PR supersedes #6516 .