Option to use old CPE error if charge exceeds one MIP #6831

wmtford · 2014-12-08T21:09:17Z

If useLegacyCPE is false and a positive value is given for maxChgOneMIP, ignore the merged status of the cluster and set the CPE error to the new value if chargePerCM is < maxChgOneMIP, else set the old value. This cut is more robust against pileup than the sensor occupancy cut used to flag a cluster as merged. We set the cut to -6000 in the config, where 6000 is a reasonable choice to turn on this selection.

cmsbuild · 2014-12-08T21:10:13Z

A new Pull Request was created by @wmtford for CMSSW_7_4_X.

Option to use old CPE error if charge exceeds one MIP

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

slava77 · 2014-12-08T21:38:28Z

Hi Bill,

(unless I missed something) the current default/standard reco should remain unchanged, right?
What is the plan to enable the new switch (to choose between legacy and new)?

wmtford · 2014-12-08T22:53:28Z

Hi Slava,

I haven't had a chance to present my studies on this to any of the
relevant tracking meetings, so, sorry, I kind of sprang the PR ahead of
any real discussion. Indeed as submitted this PR will not cause any
change from the current reco (because of the negative value of the cut
parameter). I'll report at the next opportunity where the discussion
could lead to a decision to turn this on.

Bill

On 12/08/2014 02:38 PM, Slava Krutelyov wrote:

Hi Bill,

(unless I missed something) the current default/standard reco should
remain unchanged, right?
What is the plan to enable the new switch (to choose between legacy and
new)?

—
Reply to this email directly or view it on GitHub
#6831 (comment).

cmsbuild · 2014-12-09T10:05:13Z

-1
Tested at: a1b34ee
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 09-Dec-2014 10:43:58 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named SingleElectronE120EHCAL_cfi_GEN_SIM_DIGI_DIGI2RAW_RAW2DIGI_L1Reco_RECO_EI.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 09-Dec-2014 10:44:17 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_Tauola_8TeV_cfi_GEN_SIM_RECO_EI_HLT_VALIDATION.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 09-Dec-2014 10:44:45 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_ALCAPRODUCER_DQM_ENDJOB.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 09-Dec-2014 10:45:12 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_ALCAPRODUCER_DQM_ENDJOB.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 09-Dec-2014 10:45:34 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_EI_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log
----- Begin Fatal Exception 09-Dec-2014 10:46:08 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named SingleMuPt10_cfi_GEN_SIM_RECO_EI_HLT_VALIDATION.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/wpDiscriminationByIsolationMVA3_oldDMwoLT.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 09-Dec-2014 10:46:41 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_ALCA_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 09-Dec-2014 10:47:02 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 09-Dec-2014 10:52:44 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 09-Dec-2014 10:54:11 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 09-Dec-2014 11:04:26 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM_PU.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2014-12-08-1400/external/slc6_amd64_gcc491/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6831/1524/summary.html

slava77 · 2014-12-09T20:35:46Z

@cmsbuild
if CMSSW_7_4_X_2014-12-09-1400 is healthy, please rerun tests for this PR (and others that were failing as well)

cmsbuild · 2014-12-09T22:57:38Z

-1
Tested at: 4f6ba70
When I ran the RelVals I found an error in the following worklfows:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6831/1547/summary.html

wmtford · 2014-12-09T23:17:03Z

I see that workflow 1000.0 fails the DAS-Query step.

On 12/09/2014 03:57 PM, cmsbuild wrote:

-1
Tested at: 4f6ba70
4f6ba70
When I ran the RelVals I found an error in the following worklfows:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6831/1547/summary.html

—
Reply to this email directly or view it on GitHub
#6831 (comment).

cmsbuild · 2014-12-10T09:49:49Z

-1
Tested at: 4f6ba70
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 10-Dec-2014 10:48:18 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6831/1565/summary.html

slava77 · 2014-12-10T12:55:50Z

@cmsbuild
we keep getting DAS failures in jenkins tests.
It may be easier to rerun.
Since only a small fraction of workflows failed, the comparisons can still be run.

wmtford · 2014-12-11T16:17:12Z

Do I need to do anything here? We seem to be stuck?

On 12/10/14 5:55 AM, Slava Krutelyov wrote:

@cmsbuild https://github.com/cmsbuild
we keep getting DAS failures in jenkins tests.
It may be easier to rerun.
Since only a small fraction of workflows failed, the comparisons can
still be run.

—
Reply to this email directly or view it on GitHub
#6831 (comment).

slava77 · 2014-12-11T17:18:20Z

Nothing for you to do here at the moment, Bill.
I was hoping @cmsbuild to update the tests and just use that as a reference,
if not, I'll likely get to it later today.

slava77 · 2014-12-12T00:48:52Z

+1

for #6831 4f6ba70
checked in CMSSW_7_4_X_2014-12-09-1400 (test area sign475)
no changes as expected

cmsbuild · 2014-12-12T00:52:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

slava77 · 2014-12-12T15:56:16Z

@ktf @davidlange6
can we merge this?

Option to use old CPE error if charge exceeds one MIP

mtosi · 2015-01-15T18:00:30Z

ciao,
is it possible to back port this PR to 73x ?
it would be really useful in order to synch offline and HLT, indeed
(HLT developments are still done in 73x)

thanks much
@perrotta @Martin-Grunewald @wmtford @VinInn @rovere

wmtford · 2015-01-16T06:12:05Z

Hi Mia,

I can make a PR for this. Do we want the default to be UseLegacyError
True? With a customization to turn on the new CPE if 1 MIP?

Bill

On 1/15/15 11:00 AM, mia tosi wrote:

ciao,
is it possible to back port this PR to 73x ?
it would be really useful in order to synch offline and HLT, indeed
(HLT developments are still done in 73x)

thanks much
@perrotta https://github.com/perrotta @Martin-Grunewald
https://github.com/Martin-Grunewald @wmtford
https://github.com/wmtford @VinInn https://github.com/VinInn @rovere
https://github.com/rovere

—
Reply to this email directly or view it on GitHub
#6831 (comment).

Martin-Grunewald · 2015-01-16T06:12:50Z

Yes, the defaults should be sucgh that they do not change the physics behavior compared
to not having this PR!

Martin-Grunewald · 2015-01-16T06:13:40Z

Can you make the PR really asap (ie, NOW)- then we can try to get it in 731 which should
be built today. Thanks!

mtosi · 2015-01-16T06:49:19Z

as Martin wrote, yes please
the default configuration should guarantee the old behaviour

thanks a lot !

wmtford · 2015-01-16T18:06:29Z

Done, PR #7241.

Sorry for the delay; I'm 8 time zones behind.

Bill

On 01/15/2015 11:13 PM, Martin Grunewald wrote:

Can you make the PR really asap (ie, NOW)- then we can try to get it in
731 which should
be built today. Thanks!

—
Reply to this email directly or view it on GitHub
#6831 (comment).

mtosi · 2015-01-16T18:07:44Z

thanks much !!!!!

Option to use old CPE error if charge exceeds one MIP

4f6ba70

cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 8, 2014

cmsbuild added comparison-pending pending-signatures reconstruction-pending tests-pending labels Dec 8, 2014

cmsbuild added comparison-pending pending-signatures reconstruction-pending tests-rejected and removed comparison-pending pending-signatures reconstruction-pending tests-pending labels Dec 9, 2014

cmsbuild removed comparison-pending pending-signatures reconstruction-pending tests-rejected labels Dec 12, 2014

cmsbuild added comparison-pending fully-signed reconstruction-approved tests-rejected labels Dec 12, 2014

ktf added a commit that referenced this pull request Dec 12, 2014

Merge pull request #6831 from wmtford/QdxCPE

b89cf10

Option to use old CPE error if charge exceeds one MIP

ktf merged commit b89cf10 into cms-sw:CMSSW_7_4_X Dec 12, 2014

wmtford deleted the QdxCPE branch December 22, 2014 16:36

makortel mentioned this pull request Jan 8, 2015

Customize fragment to enable new strip CPE #7082

Closed

perrotta mentioned this pull request Jan 16, 2015

Option to use old CPE error if charge exceeds one MIP - 73X #7224

Closed

Martin-Grunewald mentioned this pull request Jan 16, 2015

Backport of #6831 to 73X (CPE error) #7225

Closed

perrotta mentioned this pull request Jan 16, 2015

New CPE for 1 MIP clusters (default off) #7241

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to use old CPE error if charge exceeds one MIP #6831

Option to use old CPE error if charge exceeds one MIP #6831

wmtford commented Dec 8, 2014

cmsbuild commented Dec 8, 2014

slava77 commented Dec 8, 2014

wmtford commented Dec 8, 2014

cmsbuild commented Dec 9, 2014

slava77 commented Dec 9, 2014

cmsbuild commented Dec 9, 2014

wmtford commented Dec 9, 2014

cmsbuild commented Dec 10, 2014

slava77 commented Dec 10, 2014

wmtford commented Dec 11, 2014

slava77 commented Dec 11, 2014

slava77 commented Dec 12, 2014

cmsbuild commented Dec 12, 2014

slava77 commented Dec 12, 2014

mtosi commented Jan 15, 2015

wmtford commented Jan 16, 2015

Martin-Grunewald commented Jan 16, 2015

Martin-Grunewald commented Jan 16, 2015

mtosi commented Jan 16, 2015

wmtford commented Jan 16, 2015

mtosi commented Jan 16, 2015

Option to use old CPE error if charge exceeds one MIP #6831

Option to use old CPE error if charge exceeds one MIP #6831

Conversation

wmtford commented Dec 8, 2014

cmsbuild commented Dec 8, 2014

slava77 commented Dec 8, 2014

wmtford commented Dec 8, 2014

cmsbuild commented Dec 9, 2014

slava77 commented Dec 9, 2014

cmsbuild commented Dec 9, 2014

wmtford commented Dec 9, 2014

cmsbuild commented Dec 10, 2014

slava77 commented Dec 10, 2014

wmtford commented Dec 11, 2014

slava77 commented Dec 11, 2014

slava77 commented Dec 12, 2014

cmsbuild commented Dec 12, 2014

slava77 commented Dec 12, 2014

mtosi commented Jan 15, 2015

wmtford commented Jan 16, 2015

Martin-Grunewald commented Jan 16, 2015

Martin-Grunewald commented Jan 16, 2015

mtosi commented Jan 16, 2015

wmtford commented Jan 16, 2015

mtosi commented Jan 16, 2015