New CPE for 1 MIP clusters (default off)

[wmtford]

Back port to 7_3_X new CPE for clusters passing a cut on chargePerCM. Default is not activated. New customize py will activate.

[cmsbuild]

A new Pull Request was created by @wmtford for CMSSW_7_3_X.

New CPE for 1 MIP clusters (default off)

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[perrotta]

Hi Bill.

Please, notice that the same backport was already proposed by #7225

This pull request contains the additional configuration file
RecoLocalTracker/SiStripRecHitConverter/python/customiseNewStripCPE.py
with respect to both the original #6831 and #7225, and it is therefore different from both them.

Could you please specify whether that file is needed (and why), so that release managers can decide whether to merge this pull request or #7225?

Thank you,
Andrea

[davidlange6]

or #7224 for that matter. Many PRs to chose from in this case...

---

From: perrotta [notifications@github.com]
Sent: 16 January 2015 19:26
To: cms-sw/cmssw
Subject: Re: [cmssw] New CPE for 1 MIP clusters (default off) (#7241)

Hi Bill.

Please, notice that the same backport was already proposed by #7225#7225

This pull request contains the additional configuration file
RecoLocalTracker/SiStripRecHitConverter/python/customiseNewStripCPE.py
with respect to both the original #6831#6831 and #7225#7225, and it is therefore different from both them.

Could you please specify whether that file is needed (and why), so that release managers can decide whether to merge this pull request or #7225#7225?

Thank you,
Andrea

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7241#issuecomment-70298313.

[wmtford]

Hi Andrea and David,

These three PRs are equivalent so far as I can tell, except that the
discussion over 7_4_X led to the request for a customization file. I
just assumed that it might be wanted here (where it works in reverse of
the way it does in 7_4_X). Your call as far as I'm concerned whether to
use my PR that includes it or one of the others.

Bill

On 01/16/2015 11:34 AM, David Lange wrote:

or #7224 for that matter. Many PRs to chose from in this case...

---

From: perrotta [notifications@github.com]
Sent: 16 January 2015 19:26
To: cms-sw/cmssw
Subject: Re: [cmssw] New CPE for 1 MIP clusters (default off) (#7241)

Hi Bill.

Please, notice that the same backport was already proposed by
#7225#7225

This pull request contains the additional configuration file
RecoLocalTracker/SiStripRecHitConverter/python/customiseNewStripCPE.py
with respect to both the original
#6831#6831 and
#7225#7225, and it is therefore
different from both them.

Could you please specify whether that file is needed (and why), so that
release managers can decide whether to merge this pull request or
#7225#7225?

Thank you,
Andrea

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/7241#issuecomment-70298313.

—
Reply to this email directly or view it on GitHub
#7241 (comment).

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 970482d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7241/1964/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7241/1964/summary.html

[slava77]

+1

for #7241 970482d
changes appear to be the same as made in 74X (without the actual switch to the new CPE).
jenkins confirms no changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1