Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a customisation fragment to check EventSetup usage #7000

Merged
merged 1 commit into from Jan 6, 2015
Merged

add a customisation fragment to check EventSetup usage #7000

merged 1 commit into from Jan 6, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 23, 2014

customiseCheckEventSetup:
customise a process to

  • print the list of ESSources and ESProducers
  • add a module to print all available EventSetup data
  • add a module to print all the used EventSetup data

PrintEventSetupContent:

  • migrate from legacy to 'one' module
  • reduce the number of LogSystem calls
  • add an option to make the output format consistent with that
    of PrintEventSetupDataRetrieval

PrintEventSetupDataRetrieval:

  • reduce the number of LogSystem calls

@fwyzard
add a customisation fragment to check EventSetup usage
8432fce 
customiseCheckEventSetup:
customise a process to
  - print the list of ESSources and ESProducers
  - add a module to print all available EventSetup data
  - add a module to print all the used EventSetup data

PrintEventSetupContent:
  - migrate from legacy to 'one' module
  - reduce the number of LogSystem calls
  - add an option to make the output format consistent with that
    of PrintEventSetupDataRetrieval

PrintEventSetupDataRetrieval:
  - reduce the number of LogSystem calls
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 23, 2014

backport #6783 to 7.3.x

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Dec 23, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_3_X.

add a customisation fragment to check EventSetup usage

It involves the following packages:

FWCore/Modules

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 8432fce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7000/1705/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7000/1705/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 6, 2015
@cmsbuild
Merge pull request #7000 from fwyzard/customiseCheckEventSetup_73x
3fa8147 
add a customisation fragment to check EventSetup usage
@cmsbuild cmsbuild merged commit 3fa8147 into cms-sw:CMSSW_7_3_X Jan 6, 2015
@fwyzard fwyzard deleted the customiseCheckEventSetup_73x branch January 6, 2015 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @Dr15Jones @davidlange6