Make theVerboseLevel constexpr

[Dr15Jones]

The static analyzer was complaining about the file static
theVerboseLevel in SiPixelTemplateSplit. Since the value is never
changed at run time the variable was marked as constexpr.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Make theVerboseLevel constexpr

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[slava77]

does it make sense to be static here? could just be constexpr int theVerboseLevel = 2;

[VinInn]

I think should be not static and enclosed in anonymous namespace

[Dr15Jones]

Static guarantees the symbol is not exported. I've never checked to see if anonymous namespaces have the same guarantee.

[VinInn]

that's the role of "anonymous namespace" in C++ (w/r/t static as "local-to-file" in C)

[slava77]

@Dr15Jones will you change this or do we stick to static?

[Dr15Jones]

Given all the stuff I have on my plate and that we use static much more than unnamed namespaces I'd prefer to keep it as it is.

[slava77]

@cmsbuild please test

(compile is enough)

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

@cmsbuild please test
... well, I was hoping the first time would actually work

[slava77]

Looks like jenkins stepped on itself

https://cmssdt.cern.ch/jenkins/job/auto-trigger-pr-tests/5081/console

[slava77]

.. this one is a problematic PR:

fatal: Couldn't find remote ref refs/pull/7192/head

Chris, you have most of them. Is it a special way you submit PRs?

[Dr15Jones]

It's a bug in github. It seems to happen if you tell github to create a pull request within a very short time of uploading the commits to github. I hadn't seen the problem in months so I thought they had fixed the race condition. Guess I'll have to go back to waiting 5 minutes or so before creating a pull request.

[Dr15Jones]

@ktf any ideas?

[slava77]

+1

for #7192 213f34e
tested in CMSSW_7_4_0_pre3 /test area sign489/
no changes as expected

local test requires a merge from Dr15Jones:makeStaticConstInSiPixelTemplateSplit directly instead of the upstream

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

[Dr15Jones]

@ktf Jenkins can't get the test to run. I'd bet on Slava's tests being sufficient.

[ktf]

Yeah... I'll contact github support to see if they have any insight about this.