Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make theVerboseLevel constexpr #7192

Merged
merged 1 commit into from Jan 19, 2015
Merged

Make theVerboseLevel constexpr #7192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoLocalTracker/SiPixelRecHits/src/SiPixelTemplateSplit.cc
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#define LOGERROR(x) edm::LogError(x)
#define LOGDEBUG(x) LogDebug(x)
static int theVerboseLevel = 2;
static constexpr int theVerboseLevel = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to be static here? could just be constexpr int theVerboseLevel = 2;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be not static and enclosed in anonymous namespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static guarantees the symbol is not exported. I've never checked to see if anonymous namespaces have the same guarantee.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the role of "anonymous namespace" in C++ (w/r/t static as "local-to-file" in C)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones will you change this or do we stick to static?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all the stuff I have on my plate and that we use static much more than unnamed namespaces I'd prefer to keep it as it is.

#define ENDL " "
#else
#include "SiPixelTemplateSplit.h"
Expand Down