Performance improvement in PAT helpers.py (62X) #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tTagVisitor() According to help(cms.PSet) parameters_() copies all the contained parameter objects, while in this case it is enough to iterate over the names.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_6_2_X. Performance improvement in PAT helpers.py (62X) It involves the following packages: PhysicsTools/PatAlgos @vadler can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it? |
|
+1 |
ghost
assigned
davidlt
added a commit
that referenced
this pull request
Oct 6, 2013
Performance improvement in PAT helpers.py (62X)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary copying in PAT helpers.MassSearchReplaceAnyInputTagVisitor. This can result a significant speedup in configuration parsing depending how many times massSearchReplaceAnyInputTag() function is called. Results identical dump (process.dumpPython()) in my tests. Also add unit test for the function.
Backport of PR #727.