Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastsim digirecomix fixes #7358

Merged
merged 8 commits into from Jan 26, 2015
Merged

Fastsim digirecomix fixes #7358

merged 8 commits into from Jan 26, 2015

Conversation

lveldere
Copy link
Contributor

a few fixes were made wrt #7306

  • careful comparison of fastsim cfg dumps before and after changes revealed a few cfg mistakes which are fixed
  • fastsim unit tests were fixed

@lveldere lveldere mentioned this pull request Jan 25, 2015
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jan 25, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim digirecomix fixes

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
FastSimulation/Configuration
FastSimulation/PileUpProducer

@civanch, @nclopezo, @lveldere, @boudoul, @franzoni, @mdhildreth, @cmsbuild, @srimanob, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @matt-komm, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 464dcc5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7358/2106/summary.html

- recovered option --pileup default for cmsDriver
1f78f9e 
- default input files for gen-mixing are now 8 TeV
- when postLS1 customisation is used, input files for gen-mixing are 13 TeV
- HLT step runs independent from RECO step (broken during transition to digi-reco mixing)
@cmsbuild
Copy link
Contributor

Pull request #7358 was updated. @civanch, @nclopezo, @lveldere, @boudoul, @franzoni, @mdhildreth, @cmsbuild, @srimanob, @davidlange6 can you please check and sign again.

@lveldere
Copy link
Contributor Author

@cmsbuild

I made a new commit,
could you retrigger tests?
thanks
Lukas

@lveldere
Copy link
Contributor Author

list of tests performed

  • all FastSim PU scenarios in runTheMatrix run
    (tested wfs 5.1,135.1,400.0,25400.0)
  • impact of this branch on FastSim cfgs was studied in detail
    • python cfg files were dumped for all listed wfs in 740pre5 and in this branch
    • for each dumped cfg the differences between 740pre5 and this branch were listed and understood
    • a similar comparison was done for a variation of wf 135.1 re-configured for digi-reco mixing
  • all fastsim unit tests run
  • the HLT step is shown to run independent from the RECO step

@davidlange6
Copy link
Contributor

remaining changes indeed are fastsim fixes for issues in PR - I will bypass for pre6. Please comment if there is something I missed in this PR.

davidlange6 added a commit that referenced this pull request Jan 26, 2015
@davidlange6
Merge pull request #7358 from lveldere/fastsim-digirecomix-fixes
e0ecf89 
Fastsim digirecomix fixes
@davidlange6 davidlange6 merged commit e0ecf89 into cms-sw:CMSSW_7_4_X Jan 26, 2015
@lveldere lveldere mentioned this pull request Jan 27, 2015
Merged
@lveldere lveldere deleted the fastsim-digirecomix-fixes branch January 29, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fastsim-pending operations-pending pdmv-pending pending-signatures simulation-pending tests-pending
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lveldere @cmsbuild @davidlange6