New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement postLS1 as an Era - core parts #7419
Implement postLS1 as an Era - core parts #7419
Conversation
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X. Implement postLS1 as an Era - core parts It involves the following packages: Configuration/Applications @civanch, @nclopezo, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Implement postLS1 as an Era - core parts
This is the first part of a split down #6784. The only thing it adds is
run2
,bunchspacing25ns
andbunchspacing50ns
customiseRun2EraExtras
which currently is a direct copy ofcustomisePostLS1
bunchspacing25ns
andbunchspacing50ns
are not intended to be specified by the user, ConfigBuilder adds them automatically depending on what pileup is requested.run2
will eventually be thecustomisePostLS1
customisation implemented as an era. Each portion will be added incrementally in further pull requests. Until it is complete, thecustomiseRun2EraExtras
customisation can be used to do the parts that haven't been implemented yet (currently everything).So commands that originally had
can be tested using eras with:
Eventually when
run2
is fully implemented the customisation will not be required.I tested the 1320.0 workflow (since it is one of the postLS1 ones) with and without the above replacement, then diff-ed the resulting configuration files and diff-ed the result of applying
edmConfigDump
on those files. There is absolutely no difference in the dumps, for the files themselves there are small expected differences (different customisation name, run2 era specified). Note that diff equivalency is not expected oncerun2
actually does something, for reasons that will be explained in the relevant subsequent pull requests.@davidlange6, @Dr15Jones
@franzoni - this is just the core parts, it doesn't show how to use the eras yet. I'll ping you again when there is a good example (or you can look at #6784 but there's a lot in there to wade through).