Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate the fast multifit for HLT in 740pre5, yet not using the DB inp... #7441

Merged

Conversation

emanueledimarco
Copy link
Contributor

...uts.

The default behavior is the same as before, so no change is expected. The fast version of the local reconstruction will be triggered by changing the parameters doPrefitEB and doPrefitEE via the HLT menu.

@emanueledimarco
Copy link
Contributor Author

@argiro @bendavid @fwyzard @gennai @matteosan1 @cerminar This is an intermediate PR in 7.4.X branch integrating the fast multifit version for the HLT, in order to have it in an earlier IB of 7.4.X than the last open pre7.

It still uses the inputs from python, not being dependent on the new payloads containing ECAL templates, that will be pushed when the GT will be ready.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_4_X.

integrate the fast multifit for HLT in 740pre5, yet not using the DB inp...

It involves the following packages:

RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@fwyzard
Copy link
Contributor

fwyzard commented Jan 29, 2015

@cvuosalo, @slava77, apologies, but I have to ask you if you could test and sign this as quickly as possible: we need to have it in an IB to migrate the HLT 25ns menu to the fast multifit method .

@fwyzard
Copy link
Contributor

fwyzard commented Jan 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2015

I don't see any differences in DQM or direct-fwlite comparisons in the short tests done by jenkins.
Is this expected?
If so, please update the description of the PR to mention that the added feature is not enabled and no changes are expected.

@emanueledimarco
Copy link
Contributor Author

@slava77 Yes, it is expected. The PR contains the code and the necessary switches to enable the "fast version" for the HLT: the default parameters correspond to the pre-PR configuration and will be changed directly via the HLT menu. I am updating the description of the PR.

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2015

+1

for #7441 10a9446
jenkins confirms no differences as expected
the code looks OK, the technical performance evaluation will happen when it is enabled

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 29, 2015
…0pre5

integrate the fast multifit for HLT in 740pre5, yet not using the DB inp...
@cmsbuild cmsbuild merged commit 736d624 into cms-sw:CMSSW_7_4_X Jan 29, 2015
@emanueledimarco emanueledimarco deleted the ecalmultifit-hlt-from740pre5 branch February 5, 2015 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants