Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2 alca phi stream #7471

Merged
merged 3 commits into from Jan 31, 2015
Merged

Run2 alca phi stream #7471

merged 3 commits into from Jan 31, 2015

Conversation

bmarzocc
Copy link
Contributor

New stream for Phi-Symmetry, main changes:

  • Save digis instead of rechits
  • Cut on uncalibrechit amplitude instead of rechit energy

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bmarzocc (Badder Marzocchi) for CMSSW_7_4_X.

Run2 alca phi stream

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

desc.add<double>("ampCut_endcap",12.);
desc.add<std::string>("phiSymBarrelDigiCollection","phiSymEcalDigisEB");
desc.add<std::string>("phiSymEndcapDigiCollection","phiSymEcalDigisEE");
descriptions.add("alCaPhiSymStream",desc);
descriptions.add("alCaPhiSymStream",desc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you have this line twice ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, I forgot. I'm removing it now.

@cmsbuild
Copy link
Contributor

Pull request #7471 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

You need to make a PR for 73X in case you want to test/use this code in 73X as well.

@Martin-Grunewald
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@bmarzocc
Copy link
Contributor Author

After compiling, I have tried to run this filter with a reco-sequence such as:

process.reconstruction_step = cms.Path(process.ecalLocalRecoSequence*process.hltAlCaPhiSymStream)

or with and hlt reco-sequence such as:

process.HLTDoFullUnpackingEgammaEcalSequence = cms.Sequence( process.hltEcalDigis + process.hltEcalUncalibRecHit + process.hltEcalDetIdToBeRecovered + process.hltEcalRecHit)
process.reconstruction_step = cms.Path(process.HLTDoFullUnpackingEgammaEcalSequence*process.hltAlCaPhiSymStream)

and everything works.
Do I have to do other tests?

@Martin-Grunewald
Copy link
Contributor

The please-test command was directed at cmsbuild to trigger jenkins integration tests - (btw, of course it is expected that you had tested this before making the PR...)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants