-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2 alca phi stream #7471
Run2 alca phi stream #7471
Conversation
A new Pull Request was created by @bmarzocc (Badder Marzocchi) for CMSSW_7_4_X. Run2 alca phi stream It involves the following packages: HLTrigger/special @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
desc.add<double>("ampCut_endcap",12.); | ||
desc.add<std::string>("phiSymBarrelDigiCollection","phiSymEcalDigisEB"); | ||
desc.add<std::string>("phiSymEndcapDigiCollection","phiSymEcalDigisEE"); | ||
descriptions.add("alCaPhiSymStream",desc); | ||
descriptions.add("alCaPhiSymStream",desc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you have this line twice ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right, I forgot. I'm removing it now.
You need to make a PR for 73X in case you want to test/use this code in 73X as well. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
After compiling, I have tried to run this filter with a reco-sequence such as: process.reconstruction_step = cms.Path(process.ecalLocalRecoSequence*process.hltAlCaPhiSymStream) or with and hlt reco-sequence such as: process.HLTDoFullUnpackingEgammaEcalSequence = cms.Sequence( process.hltEcalDigis + process.hltEcalUncalibRecHit + process.hltEcalDetIdToBeRecovered + process.hltEcalRecHit) and everything works. |
The please-test command was directed at cmsbuild to trigger jenkins integration tests - (btw, of course it is expected that you had tested this before making the PR...) |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
New stream for Phi-Symmetry, main changes: