Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DQM commands to the run2 era #7730

Merged
merged 2 commits into from Feb 14, 2015

Conversation

mark-grimes
Copy link

Adds the changes required for DQM to the run2 era. Note that the command is also still in the helper function, taking it out now would conflict with #7729 and having it twice is not harmful (the changes to postLS1Customs.py here are removing old commands, and these changes are common to the two PRs).

Testing has been limited, although there are no changes unless the run2 era is explicitly activated. I just made sure everything parses and the particular changes take effect. I'll do full comparisons between the customisation and era output once all the pull requests are in.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Add DQM commands to the run2 era

It involves the following packages:

DQM/L1TMonitor
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

bypassing era prs until fully working

davidlange6 added a commit that referenced this pull request Feb 14, 2015
@davidlange6 davidlange6 merged commit 7060f94 into cms-sw:CMSSW_7_4_X Feb 14, 2015
@mark-grimes mark-grimes deleted the convertPostLS1ToEra_DQM branch February 14, 2015 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants