Add SMatrix<double,2> used as return type for MET::getSignificanceMatrix

[dan131riley]

Add ROOT::Math::SMatrix<double,2> to DataFormats/Math. This type is not stored but is used as the return type of MET::getSignificanceMatrix(), so a dictionary is needed for that function to be called from FWLite interpreted code (e.g., PyROOT). For details see:

https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3312/1.html

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_7_4_X.

Add SMatrix<double,2> used as return type for MET::getSignificanceMatrix

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

ok, so we'll keep it on hold.

Just visually, I don't understand why this change is helping
(https://github.com/cms-sw/cmssw/pull/7866/files#diff-806795153c7932d1e3a684e2707f3da3R147 has the same line once you expand the typedefs. Could it be that this specific typedef is somehow just not visible in FWLite.
@Dr15Jones @wmtan would you happen to know?

[Dr15Jones]

Which typedef is the same? If it were already there then gccxml should have printed the exact type for the typedef during processing.

[slava77]

Error <2>::type is in the classes.h file already.
On Feb 19, 2015 1:10 PM, "Chris Jones" notifications@github.com wrote:

Which typedef is the same? If it were already there then gccxml should
have printed the exact type for the typedef during processing.

—
Reply to this email directly or view it on GitHub
#7866 (comment).

[Dr15Jones]

Actually, they are not the same Error<2>::type's fourth template argument is a ROOT::Math::MatRepSym<...> while SMatrix<double,2> has a fourth template argument of type ROOT::Math::MatRepStd<...>.

[slava77]

Chris, thanks, this makes sense then.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 588092b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7866/2770/summary.html

[cvuosalo]

+1

For #7866 588092b

Adds a template instantiation to provide a dictionary entry for the return value of MET::getSignificanceMatrix() so it can be called in the PyRoot interpreter. No other effects on running code would be expected.

Jenkins tests against CMSSW_7_4_X_2015-02-19-1400 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1