Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolution and pull plots to vertex validation, and fix two bugs #8009

Merged
merged 5 commits into from Mar 3, 2015

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 2, 2015

This PR adds the resolution (x, y, z, sum(pT^2); 1D and as a function of number of tracks and PU) and the pull (x, y, z) plots to the primary vertex validation. The definitions of the plots is similar to what we have for tracks in MultiTrackValidator. There are separate plots for cases when a reco vertex matches to one sim vertex and when it matches to many sim vertices (merged).

In addition, the following bugs are fixed

  • Filling of KindOfSignalPV histogram when the signal PV is not the one with largest sum(pT^2)
    • Related to this, the setting of the kind_of_signal_vertex was simplified (in a separate commit to make it easier to verify that the results don't change)
  • Setting the DQM folder for process.postProcessorHLTvertexing
    • In practice this affected only the standalone running of the postProcessorVertexStandalone sequence. In production workflows the process.postProcessorVertex did the post-processing for HLT, and process.postProcessorHLTvertexing did the post-processing for offline.

The first fix results the following change in 25ns RelValTTbar (9k events) (black old, red new)
image
i.e. events migrate from the bin !Highest!Assoc2Any to !HighestAssoc2First and !HighestAssoc2!First.

Tested in CMSSW_7_5_X_2015-02-25-1400.

@rovere @VinInn

The results should stay the same.
The DQM directory of the original postProcessorVertex was modified.
This bug didn't affect the central workflows, as both
postProcessorVertex (processing HLT folder) and
postProcessorHLTvertexing (processing the reco folder) were run. But
running the postProcessorVertexStandAlone sequence standalone was
affected.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Add resolution and pull plots to vertex validation, and fix two bugs

It involves the following packages:

Validation/RecoVertex

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

@deguio
Copy link
Contributor

deguio commented Mar 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants