New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolution and pull plots to vertex validation, and fix two bugs #8009
Conversation
The results should stay the same.
The DQM directory of the original postProcessorVertex was modified. This bug didn't affect the central workflows, as both postProcessorVertex (processing HLT folder) and postProcessorHLTvertexing (processing the reco folder) were run. But running the postProcessorVertexStandAlone sequence standalone was affected.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Add resolution and pull plots to vertex validation, and fix two bugs It involves the following packages: Validation/RecoVertex @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Add resolution and pull plots to vertex validation, and fix two bugs
This PR adds the resolution (x, y, z, sum(pT^2); 1D and as a function of number of tracks and PU) and the pull (x, y, z) plots to the primary vertex validation. The definitions of the plots is similar to what we have for tracks in MultiTrackValidator. There are separate plots for cases when a reco vertex matches to one sim vertex and when it matches to many sim vertices (merged).
In addition, the following bugs are fixed
kind_of_signal_vertex
was simplified (in a separate commit to make it easier to verify that the results don't change)process.postProcessorHLTvertexing
postProcessorVertexStandalone
sequence. In production workflows theprocess.postProcessorVertex
did the post-processing for HLT, andprocess.postProcessorHLTvertexing
did the post-processing for offline.The first fix results the following change in 25ns RelValTTbar (9k events) (black old, red new)
i.e. events migrate from the bin
!Highest!Assoc2Any
to!HighestAssoc2First
and!HighestAssoc2!First
.Tested in CMSSW_7_5_X_2015-02-25-1400.
@rovere @VinInn