Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of bugfix in 7_4_X adding ioread rules to clear transient vecto... #8222

Merged
merged 1 commit into from Mar 16, 2015

Conversation

andrewj314
Copy link
Contributor

Backport of bugfix in 7_4_X adding ioread rules clearing transient vectors in DataFormats/TauReco/src/classes_def_2.xml

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_3_X.

Backport of bugfix in 7_4_X adding ioread rules to clear transient vecto...

It involves the following packages:

DataFormats/TauReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2015

+1

for #8222 f854eec
the same changes in the same file (modulo spaces and empty lines) were signed off earlier in #8204 for 72X and #8061 for 74X.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: f854eec
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8222/3322/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 16, 2015
Backport of bugfix in 7_4_X adding ioread rules to clear transient vecto...
@davidlange6 davidlange6 merged commit 740a4f3 into cms-sw:CMSSW_7_3_X Mar 16, 2015
@roger-wolf roger-wolf deleted the transient_bugfix_7_3_X branch March 24, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants