Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable the kOutOfTime filtering of PF-rechits #8262

Merged
merged 2 commits into from Mar 15, 2015

Conversation

emanueledimarco
Copy link
Contributor

Same as the PR #8224 for 75X branch.

@argiro @bachtis @bendavid also watch this

…the ECAL spike rejection together with the topological cuts)

enable the usage of the EAL rechits recovered in case of dead trigger towers (new algorithm for the recovery in place)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_5_X.

re-enable the kOutOfTime filtering of PF-rechits

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@emanueledimarco
Copy link
Contributor Author

Same update to the PR as #8224 .

@cmsbuild
Copy link
Contributor

Pull request #8262 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 15, 2015

+1

for #8262 7c03b9e

this has the same code changes as #8224 359d1dc
a matching PR in 74X.
See comment there for a summary of changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants