Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impact parameter significance histograms to tracking DQM #8410

Merged
merged 1 commit into from Mar 20, 2015

Conversation

makortel
Copy link
Contributor

Add following histograms for impact parameter significances

  • dxy and dz wrt. both primary vertex and beam spot
  • signed 2D and 3D impact parameters wrt. primary vertex as defined in IPTools

Add a new flag doSIPPlots to control if they're filled or not. By default it is set to False, and enabled when DCA histograms are.

Tested in CMSSW_7_5_X_2015-03-15-1400. Should have no effect on any existing histogram, just adds new ones.

@rovere @VinInn @kmcdermo @mtosi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Add impact parameter significance histograms to tracking DQM

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8410/3632/summary.html
There are some workflows for which there are errors in the baseline:
401.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals

@deguio
Copy link
Contributor

deguio commented Mar 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants