Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database object for the HCAL negative energy filter #8447

Merged
merged 1 commit into from Apr 14, 2015

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Mar 20, 2015

Database object for the HCAL negative energy filter. Current filter relies on "Method 1" OOT pileup subtraction which is no longer being used. This object will allow us to remove dependence on "Method 1".

Once this code gets in and the relevant tag gets into the relval GT, the HCAL reco code will be modified to use it.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

Database object for the HCAL negative energy filter

It involves the following packages:

CondCore/HcalPlugins
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost
Copy link

ghost commented Mar 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: a4e8e5c
The relvals timed out after 1 hour.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8447/3716/summary.html

@ggovi
Copy link
Contributor

ggovi commented Apr 13, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants