New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparing alternative e-map handling #8600
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_5_X. preparing alternative e-map handling It involves the following packages: EventFilter/HcalRawToDigi @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please tests |
Hi Salavat, I suppose there will be 73X and 74X PRs with the same change, right? |
Yes, in principle. It's simple/minimal and tested to be non-intrusive by On Tue, 31 Mar 2015, Slava Krutelyov wrote:
|
+1 This PR enables the unpacker to use an alternative emap. It doesn't yet change the emap used, so it should not change run-time behavior. This PR is nearly the same as #8610 for 74X and #8614 for 73X, both of which have already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-03-29-2300 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
preparing alternative e-map handling
This is to allow for (an instance of) unpacker to use alternative emap (with appropriate label) with customized string
ElectronicsMap = cms.string("")
NB: default " " means regular GT tag.