New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing alternative e-map handling in unpacker for 74X #8610
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_4_X. Preparing alternative e-map handling in unpacker for 74X It involves the following packages: EventFilter/HcalRawToDigi @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 This PR enables the unpacker to use an alternative emap. It doesn't yet change the emap used, so it should not change run-time behavior. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-03-30-2300 show no significant differences, as expected. The Jenkins comparisons completed only for a couple of workflows for reasons not related to this PR, but, for this simple PR, they are adequate. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Preparing alternative e-map handling in unpacker for 74X
This is to allow for (an instance of) unpacker to use alternative emap (with appropriate label) with customized string
ElectronicsMap = cms.string("")
NB: default " " means regular GT tag.
Identical to what's submitted to 75X - #8600