Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not implemented method in PileupJetIdAlgo #8656

Merged

Conversation

emanueledimarco
Copy link
Contributor

otherwise this prevents the package to be linked.
This method is not wanted by default, according to the experts, see HN message: https://hypernews.cern.ch/HyperNews/CMS/get/jet-algorithms/351.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_5_X.

Remove not implemented method in PileupJetIdAlgo

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 6, 2015

+1

For #8656 5ba92fc

Very minor code change to delete the declaration of an unused and unimplemented method.

Jenkins tests against baseline CMSSW_7_5_X_2015-04-02-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Apr 7, 2015
Remove not implemented method in PileupJetIdAlgo
@cmsbuild cmsbuild merged commit 4157e05 into cms-sw:CMSSW_7_5_X Apr 7, 2015
schoef added a commit to HephyAnalysisSW/cmg-cmssw that referenced this pull request Apr 14, 2015
gpetruc added a commit to CERN-PH-CMG/cmg-cmssw that referenced this pull request Apr 14, 2015
…coJetProducers

RecoJet/JetProducers: remove declaration of  PileupJetIdentifier::computeIdVariables (backport of cms-sw/cmssw#8656)
@emanueledimarco emanueledimarco deleted the fix_pujetidalgo_740pre9 branch June 16, 2015 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants