Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 ) #8750

Merged
merged 11 commits into from Apr 21, 2015

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 15, 2015

[almost copy-paste of the message of #8664; the code is plain cherry-pick of changes made in 73X; with positive feedback from @ptcox I'm proceeding ]

This is supposed to address issues with running CSC (ME11 part) emulator on run2 data (currently broken for ME11a) and for re-emulation applications of run2 MC (currently possible from sim digis, but appears to be less convenient than done from RAW).
Additionally, the selective readout for run2 MC was fixed (currently the CSC selective readout emulation is disabled in run2 MC; everything is saved.)

  • extend CLCT processor to cover 7 CFEBs (that's how OTMB works now), this is for current data
  • pick up correct ranges for smartME11ab case for the (MC only at this point) SLHC algorithm
  • updated CLCT processor to also correctly read comparators on MC inputs if configured with unganged ME1a for "current" TMB algorithm (that's what we have in current OTMB firmware now)
  • fix CSCTriggerPrimitivesReader (minor, input names got mixed up after getByLabel -> getByToken conversion done last year)
  • added a shift of 4 CFEBs or 128 halfstrips for packed CLCTs and LCTs coming from ME1a (see notes below), they show up in SLHC-OTMB MC algorithm only. [this is the only change that affects output of Run2 MC "standard" workflows; note though that the unpacked LCTs and CLCTs are not really used, other than in the limited set of DQM and non-standard validation; if fixes in 74X are no longer possible, we can take this out and live with the ambiguous packing]
  • fixed ME1A pretrigger filling in MC by the CSCTriggerPrimitivesBuilder
  • made the packer aware of pretriggers and ALCTs showing up in ME1A detid with the SLHC-OTMB algorithm (this should make it possible to correctly emulate selective readout during packing; disabled for run2 MC)

An equivalent of this PR will be made for 75X.

Changes show up only Run2 MC "standard" DQM plots like this (me1/1a occupancies are present); there are no changes in regular reco or HLT objects.
wf1320_hostripsandwiresandclct

@slava77
Copy link
Contributor Author

slava77 commented Apr 15, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Apr 15, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X.

bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 )

It involves the following packages:

DataFormats/L1CSCTrackFinder
EventFilter/CSCRawToDigi
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @cvuosalo, @nclopezo, @mulhearn, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @valuev, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8750/7157/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77
Copy link
Contributor Author

slava77 commented Apr 15, 2015

+1

for #8750 16b7332
the same code changes as in #8664
jenkins tests show the expected behavior: no changes in the reconstructed objects; several DQM plots related to ME11 trigger primitives now correctly display ME1a and ME1b contributions (in the CSCOfflineMonitor plots)

@davidlange6
Copy link
Contributor

@mulhearn - any issues with this PR?

davidlange6 added a commit that referenced this pull request Apr 21, 2015
 bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 )
@davidlange6 davidlange6 merged commit 325f032 into cms-sw:CMSSW_7_4_X Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants