Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PF hadron calibration code (same as #8773 from 74X) #8778

Merged
merged 1 commit into from Apr 20, 2015

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 18, 2015

[messages from https://github.com//pull/8773#issue-69148590 and https://github.com//pull/8773#issuecomment-94002796]

change slightly the pseudorapidity dependency handlings
update also the default hardcoded calibration laws to match the last calibration uplaoded in the DB (hardcoded values are not used by the reco sequence)

Summary of performances :

  • hadron resolution : no significant changes
  • EH-hadrons (EM & Had. energy) response in barrel flatter
    -H-hadron response in endcap : improvement of the hadron response for low energy hadrons for 2.5<|eta|<3 (response moves from -30% to -10% in average. Bad response in that region is a general consequence of the lack of charged hadron outside the tracker acceptance), response for 2.3< |eta| < 2.5 moves from -2% to +2%

@slava77
Copy link
Contributor Author

slava77 commented Apr 18, 2015

+1

for #8778 ecf6d7b
based on observations in #8773 (comment)

@slava77
Copy link
Contributor Author

slava77 commented Apr 18, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Apr 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8778/4281/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants