Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local file system detection to handle bind mounts. #8862

Merged
merged 1 commit into from Apr 24, 2015

Conversation

bbockelm
Copy link
Contributor

Bind mounts are like a symlink on steroids - they allow admins to
graft part of the filesystem tree onto a different portion.

They show up as filesystem type "none", which we currently interpret
as a non-local filesystem.

With this patch, if a bind mount is detected, we lookup the source
of the mount and re-run local file system detection on that directory
instead.

Thus, if the bind mount is of a local filesystem, then we correctly
declare it local. This patch was tested on a T0 VM which hit this
issue.

Recursion is used (so bind-mounts-that-have-bind-mounts are OK);
patch includes cycle detection (although I'm not sure how one can
form a cycle, but I hate infinite recursion).

This is a forward port of #8813.

Bind mounts are like a symlink on steroids - they allow admins to
graft part of the filesystem tree onto a different portion.

They show up as filesystem type "none", which we currently interpret
as a non-local filesystem.

With this patch, if a bind mount is detected, we lookup the source
of the mount and re-run local file system detection on that directory
instead.

Thus, if the bind mount is of a local filesystem, then we correctly
declare it local.  This patch was tested on a T0 VM which hit this
issue.

Recursion is used (so bind-mounts-that-have-bind-mounts are OK);
patch includes cycle detection (although I'm not sure how one can
form a cycle, but I hate infinite recursion).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_4_X.

Allow local file system detection to handle bind mounts.

It involves the following packages:

Utilities/StorageFactory

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request Apr 24, 2015
Allow local file system detection to handle bind mounts.
@davidlange6 davidlange6 merged commit 2627e78 into cms-sw:CMSSW_7_4_X Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants