Allow local file system detection to handle bind mounts. #8862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind mounts are like a symlink on steroids - they allow admins to
graft part of the filesystem tree onto a different portion.
They show up as filesystem type "none", which we currently interpret
as a non-local filesystem.
With this patch, if a bind mount is detected, we lookup the source
of the mount and re-run local file system detection on that directory
instead.
Thus, if the bind mount is of a local filesystem, then we correctly
declare it local. This patch was tested on a T0 VM which hit this
issue.
Recursion is used (so bind-mounts-that-have-bind-mounts are OK);
patch includes cycle detection (although I'm not sure how one can
form a cycle, but I hate infinite recursion).
This is a forward port of #8813.