Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local file system detection to handle bind mounts. #8862

Merged
merged 1 commit into from Apr 24, 2015
Merged

Allow local file system detection to handle bind mounts. #8862

merged 1 commit into from Apr 24, 2015

Commits on Apr 24, 2015

  1. Allow local file system detection to handle bind mounts. 

    Bind mounts are like a symlink on steroids - they allow admins to
graft part of the filesystem tree onto a different portion.

They show up as filesystem type "none", which we currently interpret
as a non-local filesystem.

With this patch, if a bind mount is detected, we lookup the source
of the mount and re-run local file system detection on that directory
instead.

Thus, if the bind mount is of a local filesystem, then we correctly
declare it local.  This patch was tested on a T0 VM which hit this
issue.

Recursion is used (so bind-mounts-that-have-bind-mounts are OK);
patch includes cycle detection (although I'm not sure how one can
form a cycle, but I hate infinite recursion).
    @bbockelm
    bbockelm committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    caa9f6c View commit details
    Browse the repository at this point in the history