New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protection againt NaNs for IP significance histograms in Tracking DQM #9099
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Add protection againt NaNs for IP significance histograms in Tracking DQM It involves the following packages: DQM/TrackingMonitor @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
Issue in the script itself?
|
@makortel, |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
Add protection againt NaNs for IP significance histograms in Tracking DQM
In some cases
IPTools::signed*ImpactParameter*()
can return invalid result, in which case the existing code fills the histogram with NaN (0/0). This PR adds protection against it.Tested in CMSSW_7_5_X_2015-05-12-2300. Only expected change is no NaNs in these two histograms (would be visible e.g. in
Mean()
if anywhere), e.g. limited matrix shows no difference.@rovere @VinInn