Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate vertex truth matching from vertex validation EDAnalyzer #9318

Merged
merged 9 commits into from Jun 5, 2015

Conversation

makortel
Copy link
Contributor

This PR separates the vertex truth matching part of PrimaryVertexAnalyzer4PUSlimmed to a separate associator (following the mechanism introduced in #9223). Also the features of #8852 are forward-ported here by adding

The VertexAssociatorByPositionAndTracks is added to a sequence intentionally in TrackValidation_cff.py, because I intend to use it later also in track validation.

In addition, the following modifications to VertexAssociatorByTracksProducer, that would in principle have belonged to #9223, are included here

  • Migrate to fillDescriptions
  • Replace couts with LogDebug/LogTrace
  • Pass EDProductGetter to AssociationMap constructor
  • Add dictionary for VertexToTrackingVertexAssociator

Tested in CMSSW_7_5_X_2015-05-25-2300 and rebased to CMSSW_7_5_X_2015-05-27-1100 (due to dependence on #9223). No changes expected in existing histograms.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Separate vertex truth matching from vertex validation EDAnalyzer

It involves the following packages:

SimDataFormats/Associations
SimTracker/VertexAssociation
Validation/RecoTrack
Validation/RecoVertex

@civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @wmtford, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented May 28, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants