New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate vertex truth matching from vertex validation EDAnalyzer #9318
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Separate vertex truth matching from vertex validation EDAnalyzer It involves the following packages: SimDataFormats/Associations @civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Separate vertex truth matching from vertex validation EDAnalyzer
This PR separates the vertex truth matching part of PrimaryVertexAnalyzer4PUSlimmed to a separate associator (following the mechanism introduced in #9223). Also the features of #8852 are forward-ported here by adding
The VertexAssociatorByPositionAndTracks is added to a sequence intentionally in TrackValidation_cff.py, because I intend to use it later also in track validation.
In addition, the following modifications to VertexAssociatorByTracksProducer, that would in principle have belonged to #9223, are included here
Tested in CMSSW_7_5_X_2015-05-25-2300 and rebased to CMSSW_7_5_X_2015-05-27-1100 (due to dependence on #9223). No changes expected in existing histograms.
@rovere @VinInn