Turning on the HBHE negative energy filter

[igv4321]

The GT has arrived, so turning the HBHE negative energy filter on

[cmsbuild]

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

Turning on the HBHE negative energy filter

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

@igv4321 Igor, is the payload in 750pre5 GT , by any chance?
If not, which IB has it?

[cmsbuild]

The tests are being triggered in jenkins.

[igv4321]

As far as I know, the relevant payload went in in PR #9119

[igv4321]

Sorry, I originally forgot to edit the comment in the python file. Hopefully the system will still go forward with the tests.

[slava77]

+1

for #9384 bee1afc

• tested locally in CMSSW_7_5_0_pre5 /test area sign560/, including higher statistics tests (mostly of MC)
• results changed only in data (and only in 2010 and 2011 workflows (4.29, 4.17, 1000.0, 140.51), no diffs in similar 2012 tests. Differences are only in hbhereco flags, and DQM changes only in displays of the flags at a pretty low rate per hit. Since this flag information is used only for monitoring, there are no changes in the downstream objects, as expected.
  
• MC output is unchanged
• the reference ttbar PU=35@25 ns (70 events tested) has 15ms/event increase due to flagging code, which is acceptable

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1